jake/sofa
1
Fork 0
mirror of https://github.com/jakejarvis/sofa.git synced 2026-08-29 02:45:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(db): use (tmdbId, type) composite keys for title lookups

Browse Source 
The unique constraint on titles is (tmdbId, type), meaning the same
numeric TMDB ID can exist as both a movie and TV show. Several places
were keying maps by tmdbId alone, which caused UNIQUE constraint
violations when an UPDATE inadvertently changed a row's type, and
silently dropped titles when both types existed for the same ID.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
jake
2026-03-19 11:47:14 -04:00
co-authored by Claude Opus 4.6
parent 1f8b3d8f37
commit 8d1cc46875
3 changed files with 53 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/person.ts
+14 -8
View File
@@ -202,14 +202,20 @@ async function syncPersonFilmography(
const tmdbIds = [...new Set(allEntries.map((c) => c.id))];
const existingTitles = getExistingTitlesByTmdbIds(tmdbIds);
const titleIdMap = new Map<number, string>(
existingTitles.map((title) => [title.tmdbId, title.id]),
// Key by (tmdbId, type) composite since the same tmdbId can be a movie and TV show
const titleIdMap = new Map<string, string>(
existingTitles.map((title) => [`${title.tmdbId}-${title.type}`, title.id]),
);
const newEntries = allEntries.filter((entry) => !titleIdMap.has(entry.id));
const newEntries = allEntries.filter(
(entry) => !titleIdMap.has(`${entry.id}-${entry.media_type}`),
);
if (newEntries.length > 0) {
const shellEntries = newEntries
.filter((entry, index, arr) => arr.findIndex((e) => e.id === entry.id) === index)
.filter(
(entry, index, arr) =>
arr.findIndex((e) => e.id === entry.id && e.media_type === entry.media_type) === index,
)
.map((entry) => ({
tmdbId: entry.id,
mediaType: entry.media_type as "movie" | "tv",
@@ -225,8 +231,8 @@ async function syncPersonFilmography(
}));
const updatedMap = batchInsertShellTitlesTransaction(shellEntries, titleIdMap);
for (const [tmdbId, id] of updatedMap) {
titleIdMap.set(tmdbId, id);
for (const [key, id] of updatedMap) {
titleIdMap.set(key, id);
}
}
@@ -234,7 +240,7 @@ async function syncPersonFilmography(
let displayOrder = 0;
for (const credit of validCast) {
const titleId = titleIdMap.get(credit.id);
const titleId = titleIdMap.get(`${credit.id}-${credit.media_type}`);
if (!titleId) continue;
nextRows.push({
@@ -249,7 +255,7 @@ async function syncPersonFilmography(
}
for (const credit of validCrew) {
const titleId = titleIdMap.get(credit.id);
const titleId = titleIdMap.get(`${credit.id}-${credit.media_type}`);
if (!titleId) continue;
nextRows.push({