jake/sofa
1
Fork 0
mirror of https://github.com/jakejarvis/sofa.git synced 2026-08-29 05:05:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Harden API input validation, error handling, and optimistic rollbacks

Browse Source 
Add try/catch around `request.json()` in all POST routes to return a
400 instead of crashing on malformed bodies. Validate `type` as a
strict `"movie" | "tv"` enum in search, discover, import, and resolve
routes. Validate `tmdbId` as a positive integer. Add a
`SORT_BY_PATTERN` regex and page-range check (1–500) to the discover
route. Wrap all outbound TMDB calls in try/catch and return 502 on
failure so clients get a structured error rather than an unhandled
rejection.

Fix optimistic-update rollbacks in `use-title-actions`: capture
`prevStatus` and `prevWatches` before each mutation and restore both
atoms in the catch block for catchUp, handleMarkSeason,
handleUnmarkSeason, and single-episode toggle.

Fix a bug in `getContinueWatchingFeed` where the watchDateMap could
hold a stale date for episodes watched more than once; the map now
keeps the most-recent `watchedAt` per episode.
This commit is contained in:
jake
2026-03-05 13:16:08 -05:00
parent ff3c8a737b
commit f3a425a5a9
10 changed files with 240 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/(pages)/titles/[id]/_components/use-title-actions.ts
+18 -4
View File
@@ -31,6 +31,7 @@ export function useTitleActions() {
const catchUp = useCallback(
async (episodeIds: string[]) => {
const currentWatches = store.get(episodeWatchesAtom);
const prevStatus = store.get(userStatusAtom);
const newWatchSet = new Set(currentWatches);
for (const id of episodeIds) newWatchSet.add(id);
store.set(episodeWatchesAtom, [...newWatchSet]);
@@ -47,6 +48,8 @@ export function useTitleActions() {
`Caught up — marked ${episodeIds.length} episode${episodeIds.length > 1 ? "s" : ""} as watched`,
);
} catch {
store.set(episodeWatchesAtom, currentWatches);
store.set(userStatusAtom, prevStatus);
toast.error("Failed to catch up");
}
},
@@ -116,12 +119,13 @@ export function useTitleActions() {
store.set(watchingEpAtom, episodeId);
if (isWatched) {
const prevStatus = store.get(userStatusAtom);
store.set(
episodeWatchesAtom,
store.get(episodeWatchesAtom).filter((id) => id !== episodeId),
);
const status = store.get(userStatusAtom);
if (status === "completed") store.set(userStatusAtom, "in_progress");
if (prevStatus === "completed")
store.set(userStatusAtom, "in_progress");
try {
await unwatchEpisodeAction(episodeId);
@@ -130,15 +134,16 @@ export function useTitleActions() {
const w = store.get(episodeWatchesAtom);
if (!w.includes(episodeId))
store.set(episodeWatchesAtom, [...w, episodeId]);
store.set(userStatusAtom, prevStatus);
toast.error("Failed to unmark episode");
}
} else {
const currentWatches = store.get(episodeWatchesAtom);
const prevStatus = store.get(userStatusAtom);
if (!currentWatches.includes(episodeId)) {
store.set(episodeWatchesAtom, [...currentWatches, episodeId]);
}
const status = store.get(userStatusAtom);
if (status === null || status === "watchlist") {
if (prevStatus === null || prevStatus === "watchlist") {
store.set(userStatusAtom, "in_progress");
}
@@ -179,6 +184,7 @@ export function useTitleActions() {
episodeWatchesAtom,
store.get(episodeWatchesAtom).filter((id) => id !== episodeId),
);
store.set(userStatusAtom, prevStatus);
toast.error("Failed to mark episode");
}
}
@@ -190,6 +196,8 @@ export function useTitleActions() {
const handleMarkSeason = useCallback(
async (season: Season) => {
const prevWatches = store.get(episodeWatchesAtom);
const prevStatus = store.get(userStatusAtom);
const episodeWatches = store.get(episodeWatchesAtom);
const unwatched = season.episodes.filter(
(ep) => !episodeWatches.includes(ep.id),
@@ -217,6 +225,8 @@ export function useTitleActions() {
`Watched all of ${season.name ?? `Season ${season.seasonNumber}`}`,
);
} catch {
store.set(episodeWatchesAtom, prevWatches);
store.set(userStatusAtom, prevStatus);
toast.error("Failed to mark some episodes");
}
},
@@ -225,6 +235,8 @@ export function useTitleActions() {
const handleUnmarkSeason = useCallback(
async (season: Season) => {
const prevWatches = store.get(episodeWatchesAtom);
const prevStatus = store.get(userStatusAtom);
const seasonEpIds = new Set(season.episodes.map((ep) => ep.id));
store.set(
episodeWatchesAtom,
@@ -239,6 +251,8 @@ export function useTitleActions() {
`Unwatched all of ${season.name ?? `Season ${season.seasonNumber}`}`,
);
} catch {
store.set(episodeWatchesAtom, prevWatches);
store.set(userStatusAtom, prevStatus);
toast.error("Failed to unmark some episodes");
}
},