fix(core): allow scheduler jitter in update-check and telemetry throttles

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
jakeandClaude Sonnet 5.5 committed 2026-10-04 17:17:18 -04:00
1 parent 98fd236b5c
commit 57aaa5e7d2
4 files changed
+69 -4

No files matched your search

+13
View File
@@ -91,6 +91,19 @@ describe("performTelemetryReport", () => {
expect(globalThis.fetch).toHaveBeenCalledOnce();
});
test("reports on the next daily run despite last run's latency", async () => {
setSetting("telemetryEnabled", "true");
const lastReported = new Date(TEST_NOW.getTime() - (24 * 60 * 60 * 1000 - 30_000));
setSetting("telemetryLastReportedAt", lastReported.toISOString());
vi.spyOn(globalThis, "fetch").mockImplementation(
(async () => new Response(null, { status: 200 })) as unknown as typeof fetch,
);
await performTelemetryReport();
expect(globalThis.fetch).toHaveBeenCalledOnce();
});
test("does not throw on fetch failure", async () => {
setSetting("telemetryEnabled", "true");
+48 -2
View File
@@ -1,6 +1,24 @@
import { describe, expect, test } from "vitest";
import { afterAll, beforeAll, beforeEach, describe, expect, test, vi } from "vitest";
import { isNewerVersion } from "../src/update-check";
import { clearAllTables } from "@sofa/test/db";
import { setSetting } from "../src/settings";
import { isNewerVersion, performUpdateCheck } from "../src/update-check";
const TEST_NOW = new Date("2026-03-01T12:00:00Z");
beforeAll(() => {
vi.useFakeTimers();
vi.setSystemTime(TEST_NOW);
});
afterAll(() => {
vi.useRealTimers();
});
beforeEach(() => {
clearAllTables();
});
describe("isNewerVersion", () => {
test("newer major version", () => {
@@ -43,3 +61,31 @@ describe("isNewerVersion", () => {
expect(isNewerVersion("v1.0.0", "v1.0.0")).toBe(false);
});
});
describe("performUpdateCheck", () => {
test("checks again on the next 6-hour run despite last run's latency", async () => {
const lastChecked = new Date(TEST_NOW.getTime() - (6 * 60 * 60 * 1000 - 30_000));
setSetting("updateCheckLastCheckedAt", lastChecked.toISOString());
vi.spyOn(globalThis, "fetch").mockImplementation(
(async () =>
new Response(JSON.stringify({ version: "9.9.9", release_url: "https://x" }), {
status: 200,
headers: { "Content-Type": "application/json" },
})) as unknown as typeof fetch,
);
const result = await performUpdateCheck();
expect(globalThis.fetch).toHaveBeenCalledOnce();
expect(result.latestVersion).toBe("9.9.9");
});
test("skips when checked within the last few minutes", async () => {
setSetting("updateCheckLastCheckedAt", new Date(TEST_NOW.getTime() - 60_000).toISOString());
const fetchSpy = vi.spyOn(globalThis, "fetch");
await performUpdateCheck();
expect(fetchSpy).not.toHaveBeenCalled();
});
});