diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cc401a46..7452dc60 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -63,3 +63,40 @@ jobs: with: name: lhci-results path: ./.lighthouseci + + lint: + runs-on: ubuntu-latest + if: "!contains(github.event.head_commit.message, '[skip ci]')" + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 1 + lfs: false + - uses: actions/setup-node@v2 + with: + node-version: 14.x + - name: Get Yarn cache path + # https://github.com/actions/cache/blob/master/examples.md#node---yarn + # https://github.com/actions/cache/issues/60 + id: yarn-cache + run: echo "::set-output name=dir::$(yarn cache dir)" + - name: Cache dependencies + uses: actions/cache@v2 + with: + path: ${{ steps.yarn-cache.outputs.dir }} + key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} + restore-keys: | + ${{ runner.os }}-yarn- + - name: Install dependencies + run: yarn install --no-ignore-optional --frozen-lockfile + - name: Audit dependencies + run: yarn audit || true + continue-on-error: true + - name: Build preview + run: yarn build:hugo --environment development --baseURL / --buildDrafts --buildFuture + - name: Lint + run: yarn lint + - name: Percy snapshots + uses: percy/snapshot-action@v0.1.2 + env: + PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }} diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml deleted file mode 100644 index c84153dc..00000000 --- a/.github/workflows/lint.yml +++ /dev/null @@ -1,48 +0,0 @@ -name: Lint - -# this step was separated out from ci.yml because of changes to how secrets are handled: -# https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ - -on: - push: - branches: - - main - pull_request: - -jobs: - lint: - runs-on: ubuntu-latest - if: "!contains(github.event.head_commit.message, '[skip ci]')" - steps: - - uses: actions/checkout@v2 - with: - fetch-depth: 1 - lfs: false - - uses: actions/setup-node@v2 - with: - node-version: 14.x - - name: Get Yarn cache path - # https://github.com/actions/cache/blob/master/examples.md#node---yarn - # https://github.com/actions/cache/issues/60 - id: yarn-cache - run: echo "::set-output name=dir::$(yarn cache dir)" - - name: Cache dependencies - uses: actions/cache@v2 - with: - path: ${{ steps.yarn-cache.outputs.dir }} - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.os }}-yarn- - - name: Install dependencies - run: yarn install --no-ignore-optional --frozen-lockfile - - name: Audit dependencies - run: yarn audit || true - continue-on-error: true - - name: Build preview - run: yarn build:hugo --environment development --baseURL / --buildDrafts --buildFuture - - name: Lint - run: yarn lint - - name: Percy snapshots - uses: percy/snapshot-action@v0.1.2 - env: - PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }} diff --git a/.lighthouserc.json b/.lighthouserc.json index 6183ed60..3ff637d4 100644 --- a/.lighthouserc.json +++ b/.lighthouserc.json @@ -10,6 +10,7 @@ "link-text": "warn", "long-tasks": "warn", "non-composited-animations": "warn", + "tap-targets": "warn", "total-byte-weight": ["warn", {"minScore": 0.9}], "unminified-javascript": "warn", "unsized-images": "warn", diff --git a/package.json b/package.json index 7025b75b..c1d6ee15 100644 --- a/package.json +++ b/package.json @@ -58,7 +58,7 @@ "postcss-focus": "^5.0.1", "postcss-import": "^14.0.1", "postcss-reporter": "^7.0.2", - "postcss-svgo": "^5.0.0", + "postcss-svgo": "^4.0.3", "prettier": "^2.2.1", "rimraf": "^3.0.2", "stylelint": "~13.12.0", diff --git a/yarn.lock b/yarn.lock index 506cefc0..87af2bd5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4116,19 +4116,25 @@ postcss-sorting@^5.0.1: lodash "^4.17.14" postcss "^7.0.17" -postcss-svgo@^5.0.0: - version "5.0.0" - resolved "https://registry.yarnpkg.com/postcss-svgo/-/postcss-svgo-5.0.0.tgz#c8d806e573394ab24f1e233cac5be4c199e9f1b2" - integrity sha512-M3/VS4sFI1Yp9g0bPL+xzzCNz5iLdRUztoFaugMit5a8sMfkVzzhwqbsOlD8IFFymCdJDmXmh31waYHWw1K4BA== +postcss-svgo@^4.0.3: + version "4.0.3" + resolved "https://registry.yarnpkg.com/postcss-svgo/-/postcss-svgo-4.0.3.tgz#343a2cdbac9505d416243d496f724f38894c941e" + integrity sha512-NoRbrcMWTtUghzuKSoIm6XV+sJdvZ7GZSc3wdBN0W19FTtp2ko8NqLsgoh/m9CzNhU3KLPvQmjIwtaNFkaFTvw== dependencies: - postcss-value-parser "^4.1.0" - svgo "^2.3.0" + postcss "^7.0.0" + postcss-value-parser "^3.0.0" + svgo "^1.0.0" postcss-syntax@^0.36.2: version "0.36.2" resolved "https://registry.yarnpkg.com/postcss-syntax/-/postcss-syntax-0.36.2.tgz#f08578c7d95834574e5593a82dfbfa8afae3b51c" integrity sha512-nBRg/i7E3SOHWxF3PpF5WnJM/jQ1YpY9000OaVXlAQj6Zp/kIqJxEDWIZ67tAd7NLuk7zqN4yqe9nc0oNAOs1w== +postcss-value-parser@^3.0.0: + version "3.3.1" + resolved "https://registry.yarnpkg.com/postcss-value-parser/-/postcss-value-parser-3.3.1.tgz#9ff822547e2893213cf1c30efa51ac5fd1ba8281" + integrity sha512-pISE66AbVkp4fDQ7VHBwRNXzAAKJjw4Vw7nWI/+Q3vuly7SNfgYXvm6i5IgFylHGK5sP/xHAbB7N49OS4gWNyQ== + postcss-value-parser@^4.0.0, postcss-value-parser@^4.0.2, postcss-value-parser@^4.1.0: version "4.1.0" resolved "https://registry.yarnpkg.com/postcss-value-parser/-/postcss-value-parser-4.1.0.tgz#443f6a20ced6481a2bda4fa8532a6e55d789a2cb" @@ -4143,7 +4149,7 @@ postcss@^6.x, postcss@^8.1.4, postcss@^8.2.4, postcss@^8.x: nanoid "^3.1.22" source-map "^0.6.1" -postcss@^7.0.14, postcss@^7.0.17, postcss@^7.0.2, postcss@^7.0.21, postcss@^7.0.26, postcss@^7.0.31, postcss@^7.0.32, postcss@^7.0.35, postcss@^7.0.6: +postcss@^7.0.0, postcss@^7.0.14, postcss@^7.0.17, postcss@^7.0.2, postcss@^7.0.21, postcss@^7.0.26, postcss@^7.0.31, postcss@^7.0.32, postcss@^7.0.35, postcss@^7.0.6: version "7.0.35" resolved "https://registry.yarnpkg.com/postcss/-/postcss-7.0.35.tgz#d2be00b998f7f211d8a276974079f2e92b970e24" integrity sha512-3QT8bBJeX/S5zKTTjTCIjRF3If4avAT6kqxcASlTWEtAFCb9NH0OUxNDfgZSWdP5fJnBYCMEWkIFfWeugjzYMg== @@ -5015,7 +5021,7 @@ svg-tags@^1.0.0: resolved "https://registry.yarnpkg.com/svg-tags/-/svg-tags-1.0.0.tgz#58f71cee3bd519b59d4b2a843b6c7de64ac04764" integrity sha1-WPcc7jvVGbWdSyqEO2x95krAR2Q= -svgo@^1.3.2: +svgo@^1.0.0, svgo@^1.3.2: version "1.3.2" resolved "https://registry.yarnpkg.com/svgo/-/svgo-1.3.2.tgz#b6dc511c063346c9e415b81e43401145b96d4167" integrity sha512-yhy/sQYxR5BkC98CY7o31VGsg014AKLEPxdfhora76l36hD9Rdy5NZA/Ocn6yayNPgSamYdtX2rFJdcv07AYVw== @@ -5034,7 +5040,7 @@ svgo@^1.3.2: unquote "~1.1.1" util.promisify "~1.0.0" -svgo@^2.1.0, svgo@^2.3.0: +svgo@^2.1.0: version "2.3.0" resolved "https://registry.yarnpkg.com/svgo/-/svgo-2.3.0.tgz#6b3af81d0cbd1e19c83f5f63cec2cb98c70b5373" integrity sha512-fz4IKjNO6HDPgIQxu4IxwtubtbSfGEAJUq/IXyTPIkGhWck/faiiwfkvsB8LnBkKLvSoyNNIY6d13lZprJMc9Q==