re-use feed.(xml,atom) logic

lib/build-feed.ts

@@ -1,8 +1,19 @@
 import { Feed } from "feed";
 import { getAllNotes } from "./parse-notes";
 import * as config from "./config";
+import type { GetServerSidePropsContext, PreviewData } from "next";
+import type { ParsedUrlQuery } from "querystring";
 
-export const buildFeed = () => {
+// handles literally *everything* about building the server-side rss/atom feeds and writing the response.
+// all the page needs to do is `return buildFeed(context, { format: "rss" })` from getServerSideProps.
+
+export const buildFeed = (
+  context: GetServerSidePropsContext<ParsedUrlQuery, PreviewData>,
+  options?: { type: "rss" | "atom" }
+): { props: Record<string, unknown> } => {
+  const { res } = context;
+
+  // https://github.com/jpmonette/feed#example
   const feed = new Feed({
     id: `${config.baseUrl}/`,
     link: `${config.baseUrl}/`,
@@ -22,6 +33,7 @@ export const buildFeed = () => {
     },
   });
 
+  // add notes separately using their frontmatter
   const notes = getAllNotes();
   notes.forEach((note) => {
     feed.addItem({
@@ -40,5 +52,21 @@ export const buildFeed = () => {
     });
   });
 
-  return feed;
+  // cache on edge for one hour
+  res.setHeader("cache-control", "s-maxage=3600, stale-while-revalidate");
+
+  // generates RSS by default
+  if (options?.type === "atom") {
+    res.setHeader("content-type", "application/atom+xml; charset=utf-8");
+    res.write(feed.atom1());
+  } else {
+    res.setHeader("content-type", "application/rss+xml; charset=utf-8");
+    res.write(feed.rss2());
+  }
+
+  res.end();
+
+  return {
+    props: {},
+  };
 };

pages/feed.atom.ts

@@ -2,18 +2,7 @@ import { buildFeed } from "../lib/build-feed";
 import type { GetServerSideProps } from "next";
 
 export const getServerSideProps: GetServerSideProps = async (context) => {
-  const feed = buildFeed();
+  return buildFeed(context, { type: "atom" });
-  const { res } = context;
-
-  res.setHeader("content-type", "application/atom+xml; charset=utf-8");
-  // cache on edge for one hour
-  res.setHeader("cache-control", "s-maxage=3600, stale-while-revalidate");
-  res.write(feed.atom1());
-  res.end();
-
-  return {
-    props: {},
-  };
 };
 
 // eslint-disable-next-line import/no-anonymous-default-export

pages/feed.xml.ts

@@ -2,18 +2,7 @@ import { buildFeed } from "../lib/build-feed";
 import type { GetServerSideProps } from "next";
 
 export const getServerSideProps: GetServerSideProps = async (context) => {
-  const feed = buildFeed();
+  return buildFeed(context, { type: "rss" });
-  const { res } = context;
-
-  res.setHeader("content-type", "application/rss+xml; charset=utf-8");
-  // cache on edge for one hour
-  res.setHeader("cache-control", "s-maxage=3600, stale-while-revalidate");
-  res.write(feed.rss2());
-  res.end();
-
-  return {
-    props: {},
-  };
 };
 
 // eslint-disable-next-line import/no-anonymous-default-export

pages/site.webmanifest.ts

@@ -1,8 +1,6 @@
 import * as config from "../lib/config";
 import type { GetServerSideProps } from "next";
 
-const SiteManifest = () => null;
-
 export const getServerSideProps: GetServerSideProps = async (context) => {
   const manifest = {
     name: config.siteName,
@@ -23,7 +21,7 @@ export const getServerSideProps: GetServerSideProps = async (context) => {
   // https://developer.mozilla.org/en-US/docs/Web/Manifest#deploying_a_manifest
   res.setHeader("content-type", "application/manifest+json; charset=utf-8");
   // cache on edge for one day
-  res.setHeader("cache-control", "s-maxage=86400, stale-while-revalidate");
+  res.setHeader("cache-control", "s-maxage=604800, stale-while-revalidate");
   res.write(JSON.stringify(manifest));
   res.end();
 
@@ -32,4 +30,5 @@ export const getServerSideProps: GetServerSideProps = async (context) => {
   };
 };
 
-export default SiteManifest;
+// eslint-disable-next-line import/no-anonymous-default-export
+export default () => null;

pages/sitemap.xml.ts

@@ -36,9 +36,9 @@ export const getServerSideProps: GetServerSideProps = async (context) => {
   // make all relative URLs absolute
   pages.map((page) => (page.loc = `${baseUrl}${page.loc}`));
 
-  // cache on edge for one hour
+  // cache on edge for 12 hours
   const { res } = context;
-  res.setHeader("cache-control", "s-maxage=3600, stale-while-revalidate");
+  res.setHeader("cache-control", "s-maxage=43200, stale-while-revalidate");
 
   // next-sitemap takes care of the rest of the response for us
   return getServerSideSitemap(context, pages);

types/index.d.ts

@@ -6,7 +6,7 @@ export type NoteMetaType = {
   date: string;
   slug: string;
   permalink: string;
-  description?: string;
+  description: string;
   image?: string;
   tags?: string[];
   readingMins?: number;