jake/jarv.is
1
Fork 0
mirror of https://github.com/jakejarvis/jarv.is.git synced 2026-01-10 16:22:55 -05:00
Code Issues Activity

compare origins of links instead of string comparison

Browse Source
This commit is contained in:
Jake Jarvis
2022-05-21 11:31:32 -04:00
parent 9b0adae9ed
commit 90a9512c62
4 changed files with 31 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
components/Link/Link.tsx
View File

@@ -1,5 +1,6 @@
import NextLink from "next/link";
import { styled } from "../../lib/styles/stitches.config";
import { baseUrl } from "../../lib/config";
import type { ComponentProps } from "react";
import type { LinkProps as NextLinkProps } from "next/link";
@@ -42,7 +43,7 @@ export type LinkProps = Omit<ComponentProps<typeof StyledLink>, "href"> &
const Link = ({ href, rel, target, prefetch = false, underline = true, openInNewTab, ...rest }: LinkProps) => {
// This component auto-detects whether or not this link should open in the same window (the default for internal
// links) or a new tab (the default for external links). Defaults can be overridden with `openInNewTab={true}`.
const isExternal = typeof href === "string" ? href.charAt(0) !== "/" && href.charAt(0) !== "#" : false;
const isExternal = typeof href === "string" ? new URL(href as string, baseUrl).origin !== baseUrl : false;
if (openInNewTab || isExternal) {
return (