jake/jarv.is
1
Fork 0
mirror of https://github.com/jakejarvis/jarv.is.git synced 2025-07-21 11:41:18 -04:00
Code Issues Activity

fix window !== undefined checks

Browse Source
This commit is contained in:
Jake Jarvis
2021-11-24 18:02:58 -05:00
parent 3d445c5c8d
commit 037fff0841
2 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
assets/js/src/hits.js
View File

@@ -32,11 +32,8 @@ const Counter = (props) => {
); );
}; };
// don't continue if there isn't a span#meta-hits element on this page // page must have a div#meta-hits-counter element to continue
const wrapper = document.querySelector("div#meta-hits-counter"); if (typeof window !== "undefined" && document.querySelector("div#meta-hits-counter")) {
// page must have both span#meta-hits and canonical URL to enter
if (typeof window !== "undefined" && wrapper) {
// use <link rel="canonical"> to deduce a consistent identifier for this page // use <link rel="canonical"> to deduce a consistent identifier for this page
const canonical = canonicalUrl({ const canonical = canonicalUrl({
normalize: true, normalize: true,
@@ -48,7 +45,7 @@ if (typeof window !== "undefined" && wrapper) {
}); });
// get path and strip beginning and ending forward slash // get path and strip beginning and ending forward slash
const slug = new URL(canonical).pathname.replace(/^\/|\/$/g, ""); const slug = new URL(canonical).pathname.replace(/^\/|\/$/g, "") || "/";
render(<Counter slug={slug} />, wrapper); render(<Counter slug={slug} />, document.querySelector("div#meta-hits-counter"));
} }

6
assets/js/src/projects.js
View File

@@ -99,9 +99,7 @@ const RepositoryCard = (repo) => (
); );
// detect if these cards are wanted on this page (only /projects) // detect if these cards are wanted on this page (only /projects)
const wrapper = document.querySelector("div#github-cards"); if (typeof window !== "undefined" && document.querySelector("div#github-cards")) {
if (typeof window !== "undefined" && wrapper) {
// dayjs plugins: https://day.js.org/docs/en/plugin/loading-into-nodejs // dayjs plugins: https://day.js.org/docs/en/plugin/loading-into-nodejs
dayjs.extend(dayjsAdvancedFormat); dayjs.extend(dayjsAdvancedFormat);
dayjs.extend(dayjsLocalizedFormat); dayjs.extend(dayjsLocalizedFormat);
@@ -111,5 +109,5 @@ if (typeof window !== "undefined" && wrapper) {
// https://en.wikipedia.org/wiki/List_of_tz_database_time_zones#List // https://en.wikipedia.org/wiki/List_of_tz_database_time_zones#List
dayjs.tz.setDefault("America/New_York"); dayjs.tz.setDefault("America/New_York");
render(<RepositoryGrid />, wrapper); render(<RepositoryGrid />, document.querySelector("div#github-cards"));
} }