jake/commento
1
Fork 0
mirror of https://gitlab.com/commento/commento.git synced 2025-06-29 22:56:37 -04:00
Code Releases Activity

everywhere: use different session cookie names

Browse Source 
If the user is hosting the dashboard in the same domain as
their blog (with a nginx suburi, for example), the two session
cookies clash; logging into one service logs you out of the other.
With this patch, both have separate names.

Fixes https://gitlab.com/commento/commento-ce/issues/49
This commit is contained in:
Adhityaa
2018-06-20 08:59:55 +05:30
parent 76a286d884
commit ef0f45527a
45 changed files with 189 additions and 282 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
api/owner_get_test.go
View File

@ -30,16 +30,16 @@ func TestOwnerGetByEmailDNE(t *testing.T) {
}
}
func TestOwnerGetBySessionBasics(t *testing.T) {
func TestOwnerGetByOwnerTokenBasics(t *testing.T) {
failTestOnError(t, setupTestEnv())
ownerHex, _ := ownerNew("test@example.com", "Test", "hunter2")
session, _ := ownerLogin("test@example.com", "hunter2")
ownerToken, _ := ownerLogin("test@example.com", "hunter2")
o, err := ownerGetBySession(session)
o, err := ownerGetByOwnerToken(ownerToken)
if err != nil {
t.Errorf("unexpected error on ownerGetBySession: %v", err)
t.Errorf("unexpected error on ownerGetByOwnerToken: %v", err)
return
}
@ -49,11 +49,11 @@ func TestOwnerGetBySessionBasics(t *testing.T) {
}
}
func TestOwnerGetBySessionDNE(t *testing.T) {
func TestOwnerGetByOwnerTokenDNE(t *testing.T) {
failTestOnError(t, setupTestEnv())
if _, err := ownerGetBySession("does-not-exist"); err == nil {
t.Errorf("expected error not found on ownerGetBySession before creating an account")
if _, err := ownerGetByOwnerToken("does-not-exist"); err == nil {
t.Errorf("expected error not found on ownerGetByOwnerToken before creating an account")
return
}
}