jake/commento
1
Fork 0
mirror of https://gitlab.com/commento/commento.git synced 2025-06-29 22:56:37 -04:00
Code Releases Activity

api: add MAX_IDLE_PG_CONNECTIONS config variable

Browse Source 
This allows lib/pq to maintain that many idle connections to the
PostgreSQL server. The larger the number the better, but obviously, your
machine needs to be capable to maintain that many connections.

Closes https://gitlab.com/commento/commento-ce/issues/76
This commit is contained in:
Adhityaa Chandrasekar
2018-08-16 23:12:21 +05:30
parent 3339944cf2
commit 9f14a9389c
3 changed files with 53 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
api/config.go
View File

@ -3,6 +3,7 @@ package main
import (
"os"
"path/filepath"
"strconv"
"strings"
)
@ -18,6 +19,12 @@ func configParse() error {
"POSTGRES": "postgres://postgres:postgres@localhost/commento?sslmode=disable",
// PostgreSQL recommends max_connections in the order of hundreds. The default
// is 100, so let's use half that and leave the other half for other services.
// Ideally, you'd be setting this to a much higher number (for example, at the
// time of writing, commento.io uses 600). See https://wiki.postgresql.org/wiki/Number_Of_Database_Connections
"MAX_IDLE_PG_CONNECTIONS": "50",
"BIND_ADDRESS": "127.0.0.1",
"PORT": "8080",
"ORIGIN": "",
@ -55,7 +62,7 @@ func configParse() error {
}
// Mandatory config parameters
for _, env := range []string{"POSTGRES", "PORT", "ORIGIN", "FORBID_NEW_OWNERS"} {
for _, env := range []string{"POSTGRES", "PORT", "ORIGIN", "FORBID_NEW_OWNERS", "MAX_IDLE_PG_CONNECTIONS"} {
if os.Getenv(env) == "" {
logger.Errorf("missing COMMENTO_%s environment variable", env)
return errorMissingConfig
@ -95,5 +102,13 @@ func configParse() error {
os.Setenv("STATIC", static)
if num, err := strconv.Atoi(os.Getenv("MAX_IDLE_PG_CONNECTIONS")); err != nil {
logger.Errorf("invalid COMMENTO_MAX_IDLE_PG_CONNECTIONS: %v", err)
return errorInvalidConfigValue
} else if num <= 0 {
logger.Errorf("COMMENTO_MAX_IDLE_PG_CONNECTIONS should be a positive integer")
return errorInvalidConfigValue
}
return nil
}